# Grading Embedded Part Group Project 4
- Normal Submission
- Repository: https://gitlab.forge.hefr.ch/groups/team-raclette

## Grading Criterias
For the embedded part of the group project, the following applies:
- Maximum `3 Points`: A **CI/CD** pipeline has to be set and run to build the **embedded sensor**
application. It is expected that the application builds on GitLab with a docker image and
container, and that the build artifacts (application binaries) are delivered as files.
- Maximum `4 Points`: An **automated embedded application testing** has to be set up. During
the module, an example framework with some tests is provided. It is expected that this
framework and tests have been extended with additional on-target tests. It is not expected
that the tests have to be run on-target with the pipeline on GitLab (as there are limitations,
see course content). But it is expected that the on-target testes are running locally on a
machine with a docker image, and that test output and artifacts about successfully running
the tests are provided.


## CI/CD Embedded Sensor
- sensor part in https://gitlab.forge.hefr.ch/team-raclette/project-softweng/-/tree/main/pico-sensor?ref_type=heads
- extended command line for MQTT topic names, very good!
- pico-sensor-docker-build failed

*Grade:* `2 points`

## Automated Embedded Application Testing
- documented testing with local tests
- extended tests with own checks
- addede MQTT test cases
- prepared test setup in https://gitlab.forge.hefr.ch/team-raclette/project-softweng/-/blob/main/pico-sensor/.gitlab-ci.yml?ref_type=heads
- documentation about running local tests, but no result artefacts

*Grade:* `3 points`


## General feedback
- good top level README.md describing the approach
- good description with https://gitlab.forge.hefr.ch/team-raclette/project-softweng/-/blob/main/pico-sensor/README.md
- instaead of using McuMinINI (good that you found this!), the settings can be stored with the usual command line commands
- good structure with local .yml files
- could have stored the test result .xml in the repository