Support for non-consecutive ranges #13

rajayonin · 2025-10-20T16:07:46Z

rajayonin commented

2025-10-20 16:07:46 +00:00

Previously, if you had some code like this:

#schema.render(
  schema.load(
    (
      structures: (
        main: (
          bits: 16,
          ranges: (
            "3": (name: "MIE"),
            "7": (name: "MPIE"),
            "12-11": (name: "MPP"),
          ),
        ),
      ),
    ),
  ),
)

it wouldn't render the ending line of the range:

The change I made was to check if this line needed to be painted, and painting it, resulting in:

Previously, if you had some code like this: ```typst #schema.render( schema.load( ( structures: ( main: ( bits: 16, ranges: ( "3": (name: "MIE"), "7": (name: "MPIE"), "12-11": (name: "MPP"), ), ), ), ), ), ) ``` it wouldn't render the ending line of the range: ![bad](/attachments/6280f6e4-7c9f-4ffa-92c2-e517853ec63c) The change I made was to check if this line needed to be painted, and painting it, resulting in: ![good](/attachments/7da0636a-b552-4b92-8b22-1a87261b4127)

image.png

10 KiB

image.png

10 KiB

rajayonin added 1 commit 2025-10-20 16:07:46 +00:00

support for non-consecutive ranges 7ef7f653b7

Paints the start/end line of a range if there was no previous range.

rajayonin added 1 commit 2025-10-20 17:07:08 +00:00

ensure first and last bits are included when all-bit-i is set c7c777f5fa

rajayonin commented

2025-10-20 17:08:21 +00:00

We also ensure the first and last bits are set when using non-consecutive ranges w/ all-bit-i:

We also ensure the first and last bits are set when using non-consecutive ranges w/ `all-bit-i`: ![good](/attachments/c455ffa9-bb03-4ce2-a27c-2375e96ca337)

image.png

5.8 KiB

HEL added the

enhancement

label 2025-10-21 05:53:38 +00:00

HEL approved these changes 2025-10-21 06:01:42 +00:00

HEL left a comment

Looks good to me 👍
Thank you for your contribution, it is really appreciated

Looks good to me 👍 Thank you for your contribution, it is really appreciated

HEL merged commit 1dd66fd587 into dev

2025-10-21 06:02:04 +00:00

HEL referenced this issue from a commit