HEL/rivet-typst
2
1
Fork 3
Code Issues 5 Pull Requests 1 Releases 5 Activity

Support for non-consecutive ranges #13

Merged
HEL merged 2 commits from rajayonin/rivet-typst:non-consecutive-ranges into dev 2025-10-21 06:02:04 +00:00
Conversation 5 Commits 2 Files Changed 1
+30 -2
rajayonin commented 2025-10-20 16:07:46 +00:00
Contributor
Copy Link
Copy Source

Previously, if you had some code like this:

#schema.render(
  schema.load(
    (
      structures: (
        main: (
          bits: 16,
          ranges: (
            "3": (name: "MIE"),
            "7": (name: "MPIE"),
            "12-11": (name: "MPP"),
          ),
        ),
      ),
    ),
  ),
)

it wouldn't render the ending line of the range:
bad

The change I made was to check if this line needed to be painted, and painting it, resulting in:
good

Previously, if you had some code like this: ```typst #schema.render( schema.load( ( structures: ( main: ( bits: 16, ranges: ( "3": (name: "MIE"), "7": (name: "MPIE"), "12-11": (name: "MPP"), ), ), ), ), ), ) ``` it wouldn't render the ending line of the range: ![bad](/attachments/6280f6e4-7c9f-4ffa-92c2-e517853ec63c) The change I made was to check if this line needed to be painted, and painting it, resulting in: ![good](/attachments/7da0636a-b552-4b92-8b22-1a87261b4127)
image.png
10 KiB
image.png
10 KiB
rajayonin added 1 commit 2025-10-20 16:07:46 +00:00
support for non-consecutive ranges 7ef7f653b7 
Paints the start/end line of a range if there was no previous range.
rajayonin added 1 commit 2025-10-20 17:07:08 +00:00
ensure first and last bits are included when all-bit-i is set c7c777f5fa
rajayonin commented 2025-10-20 17:08:21 +00:00
Author
Contributor
Copy Link
Copy Source

We also ensure the first and last bits are set when using non-consecutive ranges w/ all-bit-i:
good

We also ensure the first and last bits are set when using non-consecutive ranges w/ `all-bit-i`: ![good](/attachments/c455ffa9-bb03-4ce2-a27c-2375e96ca337)
image.png
5.8 KiB
HEL added the enhancement label 2025-10-21 05:53:38 +00:00
HEL approved these changes 2025-10-21 06:01:42 +00:00
HEL left a comment
Owner
Copy Link
Copy Source

Looks good to me 👍
Thank you for your contribution, it is really appreciated

Looks good to me 👍 Thank you for your contribution, it is really appreciated
HEL merged commit 1dd66fd587 into dev 2025-10-21 06:02:04 +00:00
rajayonin commented 2025-10-21 07:09:37 +00:00
Author
Contributor
Copy Link
Copy Source

@HEL, when are you planning on releasing the next version of the package?

@HEL, when are you planning on releasing the next version of the package?
HEL commented 2025-10-24 17:01:41 +00:00
Owner
Copy Link
Copy Source

I'll probably release one pretty soon after checking that everything still works with Typst 0.14.0

I'll probably release one pretty soon after checking that everything still works with Typst 0.14.0
❤️ 1
HEL commented 2026-06-16 13:43:48 +00:00
Owner
Copy Link
Copy Source

soon (adverb): in or within a short time; before long; quickly

Well well well... now that Typst 0.15.0 is out, it was time for that release to be published 😅
I'm very sorry for the long wait, but v0.3.1 is finally out and available in the Universe

> soon (adverb): in or within a short time; before long; quickly Well well well... now that Typst 0.15.0 is out, it was time for that release to be published 😅 I'm very sorry for the long wait, but v0.3.1 is [finally out](https://git.kb28.ch/HEL/rivet-typst/releases/tag/v0.3.1) and available [in the Universe](https://typst.app/universe/package/rivet)
Sign in to join this conversation.
Reviewers
No Reviewers
HEL
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
HEL (Louis Heredero)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HEL/rivet-typst#13