HEL/chronos
2
3
Fork 3
Code Issues 3 Pull Requests 2 Actions Releases 4 Activity

Long comments do not wrap #4

New Issue
Closed
opened 2024-11-07 16:00:44 +00:00 by AlOwain · 2 comments
AlOwain commented 2024-11-07 16:00:44 +00:00
Copy Link
Copy Source

I am unsure about whether this is unintended behavior, or too fringe an issue to be fixed. But I thought I owed some reciprocation for the great work done on the project, when I faced the issue, I realized that the long lines did not look good anyway. Attached below is a demonstration of the behavior.

I am unsure about whether this is unintended behavior, or too fringe an issue to be fixed. But I thought I owed some reciprocation for the great work done on the project, when I faced the issue, I realized that the long lines did not look good anyway. Attached below is a demonstration of the behavior.
bug.pdf
22 KiB
HEL added the enhancementgood first issue labels 2024-11-09 00:43:47 +00:00
HEL commented 2024-11-09 00:53:21 +00:00
Owner
Copy Link
Copy Source

Hello, thank you for trying Chronos and taking the time to make this issue
There is indeed currently no attempt to restrict comments size

Avoiding page overflow might be a little tricky because of the way the widths are calculated. However, I can make it so that comments do not exceed a given width.
I have already implemented (but not yet published) a _col function to allow the user to manage the width of columns (see 56cc1b11c0). This could restrict comments to avoid overflowing
It should not be too difficult to implement, although it would require a bit more work and tinkering for the user

Hello, thank you for trying Chronos and taking the time to make this issue There is indeed currently no attempt to restrict comments size Avoiding page overflow might be a little tricky because of the way the widths are calculated. However, I can make it so that comments do not exceed a given width. I have already implemented (but not yet published) a `_col` function to allow the user to manage the width of columns (see 56cc1b11c0). This could restrict comments to avoid overflowing It should not be too difficult to implement, although it would require a bit more work and tinkering for the user
HEL commented 2024-11-09 13:45:53 +00:00
Owner
Copy Link
Copy Source

I made comments wrap to honor width restrictions given by _col elements (see ab1386e721 and b33531bef5)
I also added a max-width parameter to _col, for easier management of long comments

I made comments wrap to honor width restrictions given by `_col` elements (see ab1386e721 and b33531bef5) I also added a `max-width` parameter to `_col`, for easier management of long comments
HEL closed this issue 2024-11-09 14:00:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 good first issue
Good for newcomers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels enhancement good first issue
Milestone
No items
No Milestone
Assignees
Clear assignees
HEL (Louis Heredero)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HEL/chronos#4