Add radius parameter to block #12

2025-08-17T13:37:52+02:00

Shmerlard commented

2025-08-17 13:37:52 +02:00

this PR is just for adding support for variable radius for block elements, and added the option to set the font as an arguement like

#circuiteria.circuit(
    length: 3em,
    font: "JetBrains Mono",
    {
    import circuiteria: *
    ...
})

its my first PR so i'd like to know how to improve

this PR is just for adding support for variable radius for `block` elements, and added the option to set the font as an arguement like ``` #circuiteria.circuit( length: 3em, font: "JetBrains Mono", { import circuiteria: * ... }) ``` its my first PR so i'd like to know how to improve

Shmerlard added 2 commits 2025-08-17 13:37:52 +02:00

font arguement, radius arguement 043bb339fe

now in `block.typ` the radius is optional
and the font can be set in the canvas

small fix for radius f2ce91ec39

HEL added the enhancement label 2025-08-17 14:18:36 +02:00

HEL changed title from ~~main~~ to Add radius parameter to block

2025-08-17 14:19:27 +02:00

HEL changed target branch from main to dev

2025-08-17 14:19:33 +02:00

HEL commented

2025-08-17 14:23:27 +02:00

Hi ! 👋 Thank you for your contribution !
The radius parameter is a great addition 👍
Regarding the font, I think it would simply be better not to set it in the diagram an let the user set it from outside via a show for example.
Could you revert that change and make a separate PR ?

Hi ! 👋 Thank you for your contribution ! The radius parameter is a great addition 👍 Regarding the font, I think it would simply be better not to set it in the diagram an let the user set it from outside via a show for example. Could you revert that change and make a separate PR ?

HEL requested changes

2025-08-17 14:24:51 +02:00

Dismissed

src/circuit.typ Outdated

						
				@@ -11,2 +11,2 @@

				#let circuit(body, length: 2em) = {

				  set text(font: "Source Sans 3")

				#let circuit(body, length: 2em, font: "Source Sans 3") = {

				  set text(font: font)