prevent drawing separators on starting lines of fields #17

2025-11-20T10:06:12+01:00

rajayonin commented

2025-11-20 10:06:12 +01:00

On non-consecutive ranges, we were drawing the starting line on top of the separator, which lead to some visual glitches in some viewers (e.g. Chrome).

On non-consecutive ranges, we were drawing the starting line _on top_ of the separator, which lead to some visual glitches in some viewers (e.g. Chrome). ![before](/attachments/032b58f6-84c8-4670-8f4f-4450cdbe96e0) ![after](/attachments/cba7a173-9ba5-48df-ae0e-54fd08f76abb)

Screenshot From 2025-11-20 09-55-08.png

4.5 KiB

Screenshot From 2025-11-20 09-55-26.png

4.7 KiB

HEL requested changes

2025-11-21 15:02:58 +01:00

Dismissed

src/renderer.typ Outdated

						
				@@ -392,1 +392,4 @@

				    range-boundaries.push(start-i)

				    range-boundaries.push(end-i)

				  }

				  range-boundaries.dedup()

HEL commented

2025-11-21 15:02:25 +01:00

Not really useful since we're only checking if an index is in the list later on (line 431/434)

Also, dedup doesn't modify the array in place so the result should be reassigned to the variable

range-boundaries = range-boundaries.dedup()

Not really useful since we're only checking if an index is in the list later on (line 431/434) Also, `dedup` doesn't modify the array in place so the result should be reassigned to the variable ```typst range-boundaries = range-boundaries.dedup() ```

rajayonin commented

2025-11-24 09:18:07 +01:00

Not really useful since we're only checking if an index is in the list later on (line 431/434)

What do you suggest we do instead?

> Not really useful since we're only checking if an index is in the list later on (line 431/434) What do you suggest we do instead?

HEL commented

2025-11-24 17:13:45 +01:00

It seems like removing duplicates is not really necessary because the only time we read from the list is to check whether it contains particular indices. I'd suggest not calling dedup at all

It seems like removing duplicates is not really necessary because the only time we read from the list is to check whether it contains particular indices. I'd suggest not calling `dedup` at all

👍 1

rajayonin commented

2025-11-25 09:03:21 +01:00