HEL/rivet-typst
2
1
Fork 3
Code Issues 5 Pull Requests 1 Releases 5 Activity

prevent drawing separators on starting lines of fields #17

Merged
HEL merged 1 commits from rajayonin/rivet-typst:fix-consecutive-ranges into dev 2025-11-28 11:37:43 +00:00
Conversation 2 Commits 1 Files Changed 1
+4 -2
rajayonin commented 2025-11-20 09:06:12 +00:00
Contributor
Copy Link
Copy Source

On non-consecutive ranges, we were drawing the starting line on top of the separator, which lead to some visual glitches in some viewers (e.g. Chrome).

before
after

On non-consecutive ranges, we were drawing the starting line _on top_ of the separator, which lead to some visual glitches in some viewers (e.g. Chrome). ![before](/attachments/032b58f6-84c8-4670-8f4f-4450cdbe96e0) ![after](/attachments/cba7a173-9ba5-48df-ae0e-54fd08f76abb)
Screenshot From 2025-11-20 09-55-08.png
4.5 KiB
Screenshot From 2025-11-20 09-55-26.png
4.7 KiB
HEL requested changes 2025-11-21 14:02:58 +00:00
Dismissed
src/renderer.typ Outdated
@@ -392,1 +392,4 @@
range-boundaries.push(start-i)
range-boundaries.push(end-i)
}
range-boundaries.dedup()
HEL commented 2025-11-21 14:02:25 +00:00
Owner
Copy Link
Copy Source

Not really useful since we're only checking if an index is in the list later on (line 431/434)

Also, dedup doesn't modify the array in place so the result should be reassigned to the variable

range-boundaries = range-boundaries.dedup()
Not really useful since we're only checking if an index is in the list later on (line 431/434) Also, `dedup` doesn't modify the array in place so the result should be reassigned to the variable ```typst range-boundaries = range-boundaries.dedup() ```
rajayonin commented 2025-11-24 08:18:07 +00:00
Author
Contributor
Copy Link
Copy Source

Not really useful since we're only checking if an index is in the list later on (line 431/434)

What do you suggest we do instead?

> Not really useful since we're only checking if an index is in the list later on (line 431/434) What do you suggest we do instead?
HEL commented 2025-11-24 16:13:45 +00:00
Owner
Copy Link
Copy Source

It seems like removing duplicates is not really necessary because the only time we read from the list is to check whether it contains particular indices. I'd suggest not calling dedup at all

It seems like removing duplicates is not really necessary because the only time we read from the list is to check whether it contains particular indices. I'd suggest not calling `dedup` at all
👍 1
rajayonin commented 2025-11-25 08:03:21 +00:00
Author
Contributor
Copy Link
Copy Source

Ok, done.

Ok, done.
rajayonin marked this conversation as resolved
HEL added the bug label 2025-11-21 14:03:33 +00:00
rajayonin force-pushed fix-consecutive-ranges from 3a0331f33b to b6f2fd99b8 2025-11-25 08:02:59 +00:00 Compare
HEL approved these changes 2025-11-28 11:37:33 +00:00
HEL merged commit df7899ee4b into dev 2025-11-28 11:37:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
HEL
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels bug
Milestone
No items
No Milestone
Assignees
Clear assignees
HEL (Louis Heredero)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HEL/rivet-typst#17