HEL/rivet-typst
2
1
Fork 2
Code Issues 5 Pull Requests 2 Releases 4 Activity

prevent drawing separators on starting lines of fields #17

Open
rajayonin wants to merge 1 commits from rajayonin/rivet-typst:fix-consecutive-ranges into dev
pull from: rajayonin/rivet-typst:fix-consecutive-ranges
merge into: HEL:dev
Conversation 1 Commits 1 Files Changed 1 +4 -2
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/renderer.typ
View File

@@ -387,8 +387,10 @@
}
let range-boundaries = ()
for r in struct.ranges.values() {
let i = to-real-i(if config.ltr-bits {r.start} else {r.end})
range-boundaries.push(i)
let start-i = to-real-i(if config.ltr-bits {r.start} else {r.end})
let end-i = to-real-i(if config.ltr-bits {r.end} else {r.start}) + 1
range-boundaries.push(start-i)
range-boundaries.push(end-i)
}
rajayonin marked this conversation as resolved Outdated
HEL commented 2025-11-21 14:02:25 +00:00
Outdated
Review
Copy Link

Not really useful since we're only checking if an index is in the list later on (line 431/434)

Also, dedup doesn't modify the array in place so the result should be reassigned to the variable

range-boundaries = range-boundaries.dedup()
Not really useful since we're only checking if an index is in the list later on (line 431/434) Also, `dedup` doesn't modify the array in place so the result should be reassigned to the variable ```typst range-boundaries = range-boundaries.dedup() ```
rajayonin commented 2025-11-24 08:18:07 +00:00
Outdated
Review
Copy Link

Not really useful since we're only checking if an index is in the list later on (line 431/434)

What do you suggest we do instead?

> Not really useful since we're only checking if an index is in the list later on (line 431/434) What do you suggest we do instead?
HEL commented 2025-11-24 16:13:45 +00:00
Outdated
Review
Copy Link

It seems like removing duplicates is not really necessary because the only time we read from the list is to check whether it contains particular indices. I'd suggest not calling dedup at all

It seems like removing duplicates is not really necessary because the only time we read from the list is to check whether it contains particular indices. I'd suggest not calling `dedup` at all
👍 1
rajayonin commented 2025-11-25 08:03:21 +00:00
Outdated
Review
Copy Link

Ok, done.

Ok, done.
// Draw colors