HEL/chronos
2
3 Fork 3
Code Issues 3 Pull Requests 2 Actions Releases 4 Activity

Minor Improvements #32

Open
borbitter wants to merge 4 commits from borbitter/chronos:lifetime-arrow-begin-life-arrow-fix-no-stroke-heads into main
pull from: borbitter/chronos:lifetime-arrow-begin-life-arrow-fix-no-stroke-heads
merge into: HEL:main
Conversation 6 Commits 4 Files Changed 7
+91 -65
borbitter commented 2026-06-28 00:36:12 +00:00
First-time contributor
Copy link
Copy source

Hi,

this PR bundles a couple of - in theory - independent fixes (See commit messages)

If you want to i can do a PR for each of the commits as well.

Best borbitter.

Hi, this PR bundles a couple of - in theory - independent fixes (See commit messages) If you want to i can do a PR for each of the commits as well. Best borbitter.
borbitter added 2 commits 2026-06-28 00:36:12 +00:00
fix: do not stroke arrow heads e45144c0e8
feat: make _ret end-tip configurable 48458b054d
HEL requested review from HEL 2026-09-22 10:04:41 +00:00
src/core/draw/sequence.typ Outdated
@@ -22,0 +18,4 @@
"\\": (symbol: ">", fill: color, harpoon: true, stroke: (dash: "solid")),
"\\\\": (symbol: "straight", harpoon: true, stroke: (dash: "solid")),
"/": (symbol: ">", fill: color, harpoon: true, flip: true, stroke: (dash: "solid")),
"//": (symbol: "straight", harpoon: true, flip: true, stroke: (dash: "solid")),
HEL commented 2026-09-22 10:21:18 +00:00
Owner
Copy link
Copy source

Fine for now, will be fixed by updating CeTZ to 0.5.0+ (see https://github.com/cetz-package/cetz/issues/1054)

Fine for now, will be fixed by updating CeTZ to 0.5.0+ (see https://github.com/cetz-package/cetz/issues/1054)
src/core/draw/sequence.typ Outdated
@@ -132,3 +132,2 @@
let f = if i1 > i2 {-1} else {1}
end-info.x -= (m.width + PAR-PAD.last() * 2) / 2pt * f
(par.draw)(par, y: end-info.y)
end-info.x -= (m.width / 2 / 1pt - 1.5) * f
HEL commented 2026-09-22 10:11:21 +00:00
Owner
Copy link
Copy source

What was wrong about this positioning? It seems not to be aligned anymore with participants:

Note

The CI is currently misconfigured and stopped early before reaching this particular test case

Before After
What was wrong about this positioning? It seems not to be aligned anymore with participants: <table> <tr> <th>Before</th> <th>After</th> <tr> <td><img src="/attachments/badc6385-60a8-4bea-9a46-874f7c96ef8b" width=300></td> <td><img src="/attachments/153ba305-73f2-471a-8106-4e3ebe8d49a3" width=300></td> </tr> > [!NOTE] > The CI is currently misconfigured and stopped early before reaching this particular test case
1.png
8.2 KiB
1.png
30 KiB
borbitter commented 2026-09-23 15:45:27 +00:00
Author
First-time contributor
Copy link
Copy source

Hi, thanks for taking the time too look at it. Almost forgot about it.

From my Software Engineering lecture as well as this source https://www.uml-diagrams.org/sequence-diagrams-reference.html
and the official spec https://www.omg.org/spec/UML/2.5.1/PDF page 588 / Figure 17.13
I think the line should end at the left center of the top box and even be dashed apparently.
I dont know wether to change that. I do agree that this PR is in that regard somewhat a half hearted attempt at that as I didn't get it to work properly.
I will try to fix that now that I am aware of this PR once more.

Best borbitter, :)

Hi, thanks for taking the time too look at it. Almost forgot about it. From my Software Engineering lecture as well as this source https://www.uml-diagrams.org/sequence-diagrams-reference.html and the official spec https://www.omg.org/spec/UML/2.5.1/PDF page 588 / Figure 17.13 I think the line should end at the left center of the top box and even be dashed apparently. I dont know wether to change that. I do agree that this PR is in that regard somewhat a half hearted attempt at that as I didn't get it to work properly. I will try to fix that now that I am aware of this PR once more. Best borbitter, :)
borbitter force-pushed lifetime-arrow-begin-life-arrow-fix-no-stroke-heads from e4f919b50d to c92c807871 2026-09-25 16:51:11 +00:00 Compare
borbitter force-pushed lifetime-arrow-begin-life-arrow-fix-no-stroke-heads from c92c807871 to 0bc48685e1 2026-09-25 16:54:48 +00:00 Compare
borbitter added 1 commit 2026-09-25 17:03:37 +00:00
fix: begin of life arrow 55333bbe56
borbitter force-pushed lifetime-arrow-begin-life-arrow-fix-no-stroke-heads from 0bc48685e1 to 45d3fd4df7 2026-09-25 17:03:37 +00:00 Compare
borbitter added 1 commit 2026-09-25 17:05:39 +00:00
what changed?
CI / tests (pull_request) Canceled after 0s
Details
3ed1966b82
borbitter force-pushed lifetime-arrow-begin-life-arrow-fix-no-stroke-heads from 45d3fd4df7 to 3ed1966b82 2026-09-25 17:05:39 +00:00 Compare
borbitter commented 2026-09-25 17:30:00 +00:00
Author
First-time contributor
Copy link
Copy source

still confused why some file have changes that do not seem to change any graphical content.
any way I can diff them better than the gitea webui?

still confused why some file have changes that do not seem to change any graphical content. any way I can diff them better than the gitea webui?
HEL commented 2026-09-25 22:32:05 +00:00
Owner
Copy link
Copy source

There should be a diff directory in each test with a black and white diff image. Also, tytanic should report the number of variations (i.e. different pixels). A value < 30 is probably nothing to worry about, small text alignment issue.
These tiny artifacts can occur if the Typst / Tytanic version changes. I've been working on a little tool to help me manage these version better and avoid accidentally compiling tests with the wrong Typst version

There should be a `diff` directory in each test with a black and white diff image. Also, tytanic should report the number of variations (i.e. different pixels). A value < 30 is probably nothing to worry about, small text alignment issue. These tiny artifacts can occur if the Typst / Tytanic version changes. I've been working on a little tool to help me manage these version better and avoid accidentally compiling tests with the wrong Typst version
borbitter commented 2026-09-26 06:03:53 +00:00
Author
First-time contributor
Copy link
Copy source

Quick reply. I would propose a tool called nix ;)

Quick reply. I would propose a tool called nix ;)
borbitter commented 2026-09-26 12:54:57 +00:00
Author
First-time contributor
Copy link
Copy source

thanks for the tip with the diff dir!
I still cannot find the difference for note/styled-body/1.png
If this counts pixels correct: magick 1.png -fill white -opaque black -format '%[fx:mean]' info: its just 1 pixel thats wrong.

for group/3.png its just some minor change in outline size as far as i can tell.

thanks for the tip with the diff dir! I still cannot find the difference for note/styled-body/1.png If this counts pixels correct: ` magick 1.png -fill white -opaque black -format '%[fx:mean]' info:` its just 1 pixel thats wrong. for group/3.png its just some minor change in outline size as far as i can tell.
Some required checks failed
CI / tests (pull_request) Canceled after 0s
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u https://git.kb28.ch/borbitter/chronos lifetime-arrow-begin-life-arrow-fix-no-stroke-heads:borbitter-lifetime-arrow-begin-life-arrow-fix-no-stroke-heads
git checkout borbitter-lifetime-arrow-begin-life-arrow-fix-no-stroke-heads
Sign in to join this conversation.
Reviewers
No Reviewers
HEL
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 good first issue
Good for newcomers
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
HEL (Louis Heredero)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HEL/chronos#32