Update Electrical Components and Add Examples #9

Mathemensch · 2025-04-17T00:32:59Z

Mathemensch commented

2025-04-17 00:32:59 +00:00

First-time contributor

Refactor: Update Electrical Components and Add Examples

This PR updates the visual representation of electrical components and adds example circuits.

Changes:

Updated Electrical Components (src/elements/electrical/):
- Revised symbols for better standard compliance and readability (e.g., IEC resistor default, battery symbol for DC source, redesigned switch).
- Added explicit connection lines from ports to the component body where appropriate (sources, meters, lamp, inductor, switch).
Added Example Circuits (gallery/simple-circuit.typ):
- Created a new example file demonstrating basic usage.
- Includes examples for:
  - Series circuit (battery, two lamps).
  - RC charging circuit (battery, switch, resistor, capacitor).

**Refactor: Update Electrical Components and Add Examples** This PR updates the visual representation of electrical components and adds example circuits. **Changes:** * **Updated Electrical Components (`src/elements/electrical/`):** * Revised symbols for better standard compliance and readability (e.g., IEC resistor default, battery symbol for DC source, redesigned switch). * Added explicit connection lines from ports to the component body where appropriate (sources, meters, lamp, inductor, switch). * **Added Example Circuits (`gallery/simple-circuit.typ`):** * Created a new example file demonstrating basic usage. * Includes examples for: * Series circuit (battery, two lamps). * RC charging circuit (battery, switch, resistor, capacitor).

Mathemensch added 1 commit 2025-04-17 00:32:59 +00:00

Added some electrical components 77cda42a72

HEL commented

2025-04-17 08:11:02 +00:00

Thanks for the additions !
It looks like you forgot to commit the example circuit though

Thanks for the additions ! It looks like you forgot to commit the example circuit though

Mathemensch added 1 commit 2025-04-17 11:35:15 +00:00

Added simple-circuit e218b894bb

Mathemensch commented

2025-04-17 11:37:14 +00:00

First-time contributor

You were absolutely right.

I've added it right now.

You were absolutely right. I've added it right now.

HEL commented

2025-04-20 09:46:58 +00:00

There seem to be a small issue with inductors when placed vertically (see below). It also seems like the horizontal inductor needs a specific aspect-ratio between the width and height to display correctly
Apart from this, everything looks good to me !

Code	Result
`#circuit({ electrical.inductor( x: 0, y: 0, w: 1, h: 1, vertical: true, debug: (ports: true) ) })`

There seem to be a small issue with inductors when placed vertically (see below). It also seems like the horizontal inductor needs a specific aspect-ratio between the width and height to display correctly Apart from this, everything looks good to me ! <table> <thead><tr><th>Code</th><th>Result</th></tr></thead> <tbody><tr><td> ```typ #circuit({ electrical.inductor( x: 0, y: 0, w: 1, h: 1, vertical: true, debug: (ports: true) ) }) ``` </td> <td> ![image.png](/attachments/fe7e2d32-7d6d-40d3-8a1d-63d626abc1c2) </td></tr></tbody> </table>

image.png

5.3 KiB

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u main:Mathemensch-main

git checkout Mathemensch-main

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: HEL/circuiteria#9