HEL/circuiteria
4
7 Fork 7
Code Issues 5 Pull Requests 16 Releases 3 Activity

Update Electrical Components and Add Examples #9

Open
Mathemensch wants to merge 2 commits from Mathemensch/circuiteria:main into main
pull from: Mathemensch/circuiteria:main
merge into: HEL:main
Conversation 3 Commits 2 Files Changed 12
+1020 -1
Mathemensch commented 2025-04-17 02:32:59 +02:00
First-time contributor
Copy link
Copy source

Refactor: Update Electrical Components and Add Examples

This PR updates the visual representation of electrical components and adds example circuits.

Changes:

  • Updated Electrical Components (src/elements/electrical/):
    • Revised symbols for better standard compliance and readability (e.g., IEC resistor default, battery symbol for DC source, redesigned switch).
    • Added explicit connection lines from ports to the component body where appropriate (sources, meters, lamp, inductor, switch).
  • Added Example Circuits (gallery/simple-circuit.typ):
    • Created a new example file demonstrating basic usage.
    • Includes examples for:
      • Series circuit (battery, two lamps).
      • RC charging circuit (battery, switch, resistor, capacitor).
**Refactor: Update Electrical Components and Add Examples** This PR updates the visual representation of electrical components and adds example circuits. **Changes:** * **Updated Electrical Components (`src/elements/electrical/`):** * Revised symbols for better standard compliance and readability (e.g., IEC resistor default, battery symbol for DC source, redesigned switch). * Added explicit connection lines from ports to the component body where appropriate (sources, meters, lamp, inductor, switch). * **Added Example Circuits (`gallery/simple-circuit.typ`):** * Created a new example file demonstrating basic usage. * Includes examples for: * Series circuit (battery, two lamps). * RC charging circuit (battery, switch, resistor, capacitor).
Mathemensch added 1 commit 2025-04-17 02:32:59 +02:00
Added some electrical components 77cda42a72
HEL commented 2025-04-17 10:11:02 +02:00
Owner
Copy link
Copy source

Thanks for the additions !
It looks like you forgot to commit the example circuit though

Thanks for the additions ! It looks like you forgot to commit the example circuit though
Mathemensch added 1 commit 2025-04-17 13:35:15 +02:00
Added simple-circuit e218b894bb
Mathemensch commented 2025-04-17 13:37:14 +02:00
Author
First-time contributor
Copy link
Copy source

You were absolutely right.

I've added it right now.

You were absolutely right. I've added it right now.
HEL commented 2025-04-20 11:46:58 +02:00
Owner
Copy link
Copy source

There seem to be a small issue with inductors when placed vertically (see below). It also seems like the horizontal inductor needs a specific aspect-ratio between the width and height to display correctly
Apart from this, everything looks good to me !

CodeResult
 
#circuit({
  electrical.inductor(
    x: 0, y: 0,
    w: 1, h: 1,
    vertical: true,
    debug: (ports: true)
  )
})

image.png
There seem to be a small issue with inductors when placed vertically (see below). It also seems like the horizontal inductor needs a specific aspect-ratio between the width and height to display correctly Apart from this, everything looks good to me ! <table> <thead><tr><th>Code</th><th>Result</th></tr></thead> <tbody><tr><td> ```typ #circuit({ electrical.inductor( x: 0, y: 0, w: 1, h: 1, vertical: true, debug: (ports: true) ) }) ``` </td> <td> ![image.png](/attachments/fe7e2d32-7d6d-40d3-8a1d-63d626abc1c2) </td></tr></tbody> </table>
image.png
5.3 KiB
You are not authorized to merge this pull request.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u https://git.kb28.ch/Mathemensch/circuiteria main:Mathemensch-main
git checkout Mathemensch-main
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 documentation
Need to add or update documentation
 duplicate
This issue or pull request already exists
 enhancement
Improvement on existing feature
 feature request
Request for a new feature
 help wanted
Need some help
 invalid
Something is wrong
 new component
Request for a new component
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
HEL (Louis Heredero)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: HEL/circuiteria#9