fix end line on non-consecutive ranges ending at the highest bit not being drawn #18

ALVAROPING1 · 2026-06-05T13:08:08Z

ALVAROPING1 commented

2026-06-05 13:08:08 +00:00

Previously, if you had a non-consecutive range that ended at the highest bit of the structure, such as:

#schema.render(
  schema.load(
    (
      structures: (
        main: (
          bits: 16,
          ranges: (
            "15-14": (name: "A"),
          ),
        ),
      ),
    ),
  ),
)

The end line of the range would not be drawn:

With this change, it now gets correctly drawn:

It also works correctly when ltr-bits is set, and also avoids drawing the line if it would be on top of the left/right borders of the structure

Previously, if you had a non-consecutive range that ended at the highest bit of the structure, such as: ```typst #schema.render( schema.load( ( structures: ( main: ( bits: 16, ranges: ( "15-14": (name: "A"), ), ), ), ), ), ) ``` The end line of the range would not be drawn: <img width="539" alt="Screenshot_20260605_150441.png" src="attachments/2fe6e155-baff-4c5d-989b-70eb7158ebf9"> With this change, it now gets correctly drawn: <img width="533" alt="Screenshot_20260605_150551.png" src="attachments/3b1ebdd6-d292-4ff7-ae99-b7de634351f9"> It also works correctly when `ltr-bits` is set, and also avoids drawing the line if it would be on top of the left/right borders of the structure

Screenshot_20260605_150441.png

5.5 KiB

Screenshot_20260605_150551.png

5.5 KiB

ALVAROPING1 added 1 commit 2026-06-05 13:08:08 +00:00

fix end line on non-consecutive ranges ending at the highest bit not being drawn 9b83b4c4a8

HEL commented

2026-06-05 14:34:56 +00:00

😬 This has already been fixed but I forgot to make a release...
See #13
I'll try making one in a couple of days

😬 This has already been fixed but I forgot to make a release... See #13 I'll try making one in a couple of days

HEL closed this pull request

2026-06-05 14:34:56 +00:00